Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add suport for Amphp PSR18 Client #257

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

WIP: Add suport for Amphp PSR18 Client #257

wants to merge 1 commit into from

Conversation

thePanz
Copy link

@thePanz thePanz commented Dec 9, 2023 •
edited by dbu
Loading

Note: the use Amp\Http\Client\Psr7\PsrHttpClient is still a WIP, and the support for PSR-18 has been added only on the v2 branch

Only on that branch the PsrHttpClient is implementing the ClientInterface

Note: The library only supports the psr/http-message:v1 contract

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #240
Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Implement support for amphp/http-client-psr7

Some notes:

  1. the amphp/http-client-psr7 main branch is NOT implementing the PSR ClientInterface
  2. the v2.x branch is effectively implements the PSR ClientInterface, but relies on psr/http-message v1
  3. looks like the PSR layer is not actively maintainer (master last commit: 3 years ago, v2.x last commit: 2 years ago)
  4. there is a PR bringing the library up Adapt for latest http-client amphp/http-client-psr7#10 by @danog but not merged

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • Make ci test the installation of amphp
  • Clarify the min version required of the amphp/http-client-psr7 library
  • Update Composer/Plugin.php according to the documentation, by adding amphp/http-client-psr7

@thePanz
WIP: Add suport for Amphp PSR18 Client
a232679 
Note: the use Amp\Http\Client\Psr7\PsrHttpClient is still a WIP, and the support
for PSR-18 has been added only on the v2 branch

Only on that branch the PsrHttpClient is implementing the ClientInterface

Note: The library only supports the psr/http-message:v1 contract
@nicolas-grekas
Copy link
Collaborator

Linked PR is now merged. Until amphp/http-client-psr7#10 (comment) is resolved, this should also install guzzle's PSR-7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for amphp/http-client-psr7
2 participants
@thePanz @nicolas-grekas